- 
                Notifications
    
You must be signed in to change notification settings  - Fork 61
 
[ci] Add spelling checks #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2e1130    to
    0c1312e      
    Compare
  
    | 
           @mcbarton I think I am now stuck. I am trying to implement some check based on rojopolis/spellcheck-github-actions and its documentation to spell check the PR diff only for the markdown changes. Do you think you can have a look?  | 
    
          
 @vgvassilev You have no checkout action in the repo, so it never checks out this repo, and therefore can never find .github/workflows/spellcheck.yaml  | 
    
        
          
                .github/workflows/spellcheck.yaml
              
                Outdated
          
        
      | sources: | ||
| - "**/*.md" | ||
| - "**/*.tex" | ||
| - "**/*.txt" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think source_files in the workflow overrides this, so can probably remove sources: here
          
 Fixed but there is still something up.  | 
    
          
 I think its saying that there are no markdown files that have been changed. Try changing one to see if that is the case If it passes with a changed markdown file, then add to when the workflow will activate, like https://github.com/compiler-research/CppInterOp/blob/28ba16e97f58d0364b610bad9371bc4ea8e8b304/.github/workflows/markdown-linter.yml#L7 in CppInterOp  | 
    
| 
           Yes, but there will be PRs that don’t involve markdown changes. The check should not fail under such circumstances.  | 
    
| 
           If you don't want to only activate the workflow if a .md file is modified, then you probably need something like what I did here for the ids workflow in llvm https://github.com/llvm/llvm-project/blob/0e30999cc1bfe23678591fdb9a0052c9ce7d0099/.github/workflows/ids-check.yml#L72 . e.g. create an environment variable that is blank if no .md files is changed (or whatever file extensions your interested in), and only do the 'Run Spellcheck' section if its not blank  | 
    
4526149    to
    1fde5b4      
    Compare
  
    1fde5b4    to
    66e3896      
    Compare
  
    
No description provided.